Fix S2930 FN: Track System.Threading.CancellationTokenSource#8302
Merged
pavel-mikula-sonarsource merged 3 commits intoSonarSource:masterfrom Nov 6, 2023
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavel-mikula-sonarsource
requested changes
Nov 3, 2023
Contributor
pavel-mikula-sonarsource
left a comment
pavel-mikula-sonarsource
left a comment
There was a problem hiding this comment.
Hi Čaba, Akka and Nancy needs to be convinced a little about the value of this change :)
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
pavel-mikula-sonarsource
approved these changes
Nov 6, 2023
Contributor
pavel-mikula-sonarsource
left a comment
pavel-mikula-sonarsource
left a comment
There was a problem hiding this comment.
LGTM
New FPs are existing structural limitation of the rule itself.
| "id": "S2930", | ||
| "message": "Dispose 'engineDisposedCts' when it is no longer needed.", | ||
| "location": { | ||
| "uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/NancyEngine.cs#L98", |
Contributor
There was a problem hiding this comment.
This is a FP, as it is disposed in dispose method and we can't go cross-procedure
| "id": "S2930", | ||
| "message": "Dispose 'engineDisposedCts' when it is no longer needed.", | ||
| "location": { | ||
| "uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Nancy/src/Nancy/NancyEngine.cs#L98", |
Contributor
There was a problem hiding this comment.
Also FP, stored to a field, disposed in Dispose method
|
Kudos, SonarCloud Quality Gate passed! |
vgmello
referenced
this pull request
in ellosoft/aws-cred-mgr
Dec 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [SonarAnalyzer.CSharp](https://redirect.sonarsource.com/doc/sonar-visualstudio.html) ([source](https://github.com/SonarSource/sonar-dotnet)) | `9.12.0.78982` -> `9.14.0.81108` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>SonarSource/sonar-dotnet (SonarAnalyzer.CSharp)</summary> ### [`v9.14.0.81108`](https://github.com/SonarSource/sonar-dotnet/releases/tag/9.14.0.81108): 9.14 [Compare Source](https://github.com/SonarSource/sonar-dotnet/compare/9.12.0.78982...9.14.0.81108) Hello everyone! We are happy to announce that we now have 5 dedicated Blazor rules 🚀 🥳 Special thanks to our contributor (and former colleague) [@​sagi1623](https://github.com/sagi1623) for fixing [https://github.com/SonarSource/sonar-dotnet/pull/8302](https://github.com/SonarSource/sonar-dotnet/pull/8302). ##### Improvements - [8274](https://github.com/SonarSource/sonar-dotnet/issues/8274) - \[C#] New rule S6797: Query parameter should be of supported type - [8278](https://github.com/SonarSource/sonar-dotnet/issues/8278) - \[C#] New rule S6798: \[JSInvokable] attribute should only be used on public methods - [8275](https://github.com/SonarSource/sonar-dotnet/issues/8275) - \[C#] New rule S6800: Component parameter type should match the route parameter type constraint - [8277](https://github.com/SonarSource/sonar-dotnet/issues/8277) - \[C#] New rule S6802: Using lambda expressions in loops should be avoided in Blazor markup section - [8338](https://github.com/SonarSource/sonar-dotnet/issues/8338) - \[C#] New rule S6803: Parameters with SupplyParameterFromQuery attribute should be used only in routable components - [8228](https://github.com/SonarSource/sonar-dotnet/issues/8228) - \[C#] Deprecate S4212 - [8346](https://github.com/SonarSource/sonar-dotnet/issues/8346) - Create CFG from member node - [8271](https://github.com/SonarSource/sonar-dotnet/pull/8271) - Adding missing operation wrappers and syntax kinds to the shim layer - [8230](https://github.com/SonarSource/sonar-dotnet/issues/8230) - Update Signing Certificate - [8290](https://github.com/SonarSource/sonar-dotnet/issues/8290) - Update RSPEC before 9.14 release ##### Bug Fixes - [8310](https://github.com/SonarSource/sonar-dotnet/issues/8310) - \[C#, VB.NET] Fix S2068 AD0001: Overflow exception when a configuration file value is a number greater than Int32.MaxValue ##### False Positive - [8285](https://github.com/SonarSource/sonar-dotnet/issues/8285) - \[C#, VB.NET] Fix S2583 FP: Number constraint from remainder calculation is not correct. - [8358](https://github.com/SonarSource/sonar-dotnet/issues/8358) - \[C#] Fix S2743 FP: Arrow properties do not have static fields - [7624](https://github.com/SonarSource/sonar-dotnet/issues/7624) - \[C#] Fix S3604 FP: Primary constructors ##### False Negative - [8335](https://github.com/SonarSource/sonar-dotnet/pull/8335) - \[C#] Fix S2259 FN: FlowCaptures in Field/PropertyReference.Instance - [6050](https://github.com/SonarSource/sonar-dotnet/issues/6050) - \[C#] Fix S2930 FN: Track System.Threading.CancellationTokenSource ##### Performance - [8181](https://github.com/SonarSource/sonar-dotnet/pull/8181) - \[C#] Improve S5332 performance: Reuse compiled regex </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ellosoft/aws-cred-mgr). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6050